On Thu, 19 Nov 2026 16:06:56 GMT, Daniel Fuchs <[email protected]> wrote:

>> Matthias Baesken has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add testCancelPushFrameSent Test
>
> test/jdk/java/net/httpclient/http3/H3PushCancel.java line 421:
> 
>> 419:             assertTrue(cancelledId >= 0, "Server should receive 
>> CANCEL_PUSH");
>> 420:         }
>> 421:     }
> 
> It might be a better idea to wait forever and let the test fail in jtreg 
> timeout if the cancel is not recieved. This way we will get a thread dump 
> when that happens.

Okay. I adjusted the call.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33968#discussion_r4641652668

Reply via email to