Thanks for the comments.

I tested INTEGER case of course, but not COUNTER64 case. I should remove it
for now, although I don't think it's too hard to adjust for COUNTER64.

Emi



                                                                           
             Magnus Fromreide                                              
             <[EMAIL PROTECTED]                                             
             u.se>                                                      To 
                                       [EMAIL PROTECTED]              
             05/23/2007 11:01                                           cc 
             PM                        [EMAIL PROTECTED] 
                                       et                                  
                                                                   Subject 
                                       Re: New Rmon alarmTable implemented 
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Hello!

Thanks for your contribution, it is always nice to see it.

A few random comments:

1.  I think the header file should be stripped down to the bare minimum:
---
#ifndef ALARMTABLE_H
#define ALARMTABLE_H

void            init_alarmTable(void);

#endif
---
        but that is a style issue and mfd agrees with you, so let that
        be as it is.

2.  In alarmTable_run you process COUNTER64's by the line

                new_value = *var->val.integer;

        Does that really work?

/MF




-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to