On 30 March 2010 20:32, Magnus Fromreide <[email protected]> wrote:
> a) It won't compile due to
>
>   if (x < (y / z)

Argghhh!!!
<Sigh>
Thanks.


> b) I would probably prefer the following since it makes sense to use
>   a well known name and this define is located in an implementation
>   file.
>
>   #ifndef INT32_MAX
>   #define INT32_MAX 0x7fffffff
>   #endif

I'm always a bit wary of re-defining standard names, in case the "real"
definition is included later, and triggers a warning/error.
But I suppose that's not going to happen here, since this is all
held within a single code file.

I don't feel strongly either way, so would be quite happy to go with
the standard name here.    But we shouldto tread carefully if we ever
wanted to move this into one of the Net-SNMP header files
(e.g. <net-snmp/types.h>)


Dave

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to