On Mon, 2010-03-22 at 15:54 +0000, Dave Shield wrote: > On 21 March 2010 08:45, Dave Shield <[email protected]> wrote: > > On 20 March 2010 15:13, Robert Story <[email protected]> wrote: > >> Dave, have any other issues come up that might warrant a rc2? > > > > I've got a list of three or four possible patches sitting on my desk at > > work. > > I'll send out a CFV tomorrow. > > > Please find attached four proposed patches, which could potentially be > applied to the 5.4.x (and 5.2.x) lines. We're currently in release-freeze > for both of these branches, so could people please indicate whether or > not they would like to see these included in the 5.4.3 and 5.2.6 releases. > > It would be helpful to have an explicit vote for each individual patch: > > 1) Latch disk statistics: no / 54x only / both 54x and 52x
both -1 Adds warnings about silly compares on 32 bit platforms. Adds magic constant instead of using INT32_MAX Works differently on 32 and 64 bit if the multiplication above the comparision overflows. I think he following would be a better pattern to follow for the checks: if (vfs.f_blocks > (INT32_MAX / multiplier)) long_ret = INT32_MAX; else long_ret = vfs.f_blocks * multiplier; > 2) Missing privKey crash: no / 54x only / both 54x and 52x both +1 > 3) VACM best match: no / 54x only / both 54x and 52x both +1 > 4) MIB dir path logging: no / 54x only / both 54x and 52x both 0 /MF ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
