On Mon, 2010-12-06 at 09:39 -0800, Wes Hardaker wrote:
> The following checks for a minimum macro/function required for the DTLS
> code.  I'd like to apply it for 5.6.1 (as well as trunk):
> 
> diff --git a/net-snmp/configure.d/config_os_functions 
> b/net-snmp/configure.d/config_os_functions
> index 856e944..25576da 100644
> --- a/net-snmp/configure.d/config_os_functions
> +++ b/net-snmp/configure.d/config_os_functions
> @@ -294,3 +294,24 @@ esac
>  AC_MSG_RESULT($netsnmp_PRI32)
>  AC_DEFINE_UNQUOTED([NETSNMP_PRI32], ["$netsnmp_PRI32"],
>                     [Size prefix to use to printf a uint32_t])
> +
> +# check to see if the openssl is good enough for DTLS
> +# (BIO_dgram_get_peer is a macro, not a true function)
> +if echo " $transport_result_list " | $GREP "DTLS" > /dev/null; then
> +    AC_CACHE_VAL(
> +       ac_cv_bio_dgram_get_peer,

Please, netsnmp_cv_bio_dgram_get_peer. This is not an test from the
autoconf (ac) namespace but rather a test from the netsnmp namespace.

> +       AC_MSG_CHECKING([[for BIO_dgram_get_peer]])

This looks like it begs for AC_CACHE_CHECK instead of AC_CACHE_VAL but
that rewrite can be postponed.

> +       [
> +        oldLIBS="$LIBS"
> +        LIBS="$LIBS -lcrypto"
> +        AC_TRY_LINK(

TRY_LINK to make sure that the expanded macro can be linked, right? If
not then I think TRY_COMPILE would be enough.

> +         [#include <openssl/bio.h>],
> +         [BIO_dgram_get_peer(NULL, NULL);],,
> +         AC_MSG_ERROR([DTLS support requires a newer version of OpenSSL]))

I would prefer if this error showed up somewhere close to the transport
search code and not down here but if could be moved later.

> +        LIBS="$oldLIBS"
> +       ]
> +       AC_MSG_RESULT(yes)
> +    )
> +fi
> +

+1

/MF


------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus 
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to