>>>>> On Mon, 06 Dec 2010 21:12:47 +0100, Magnus Fromreide 
>>>>> <ma...@lysator.liu.se> said:

MF> Please, netsnmp_cv_bio_dgram_get_peer. This is not an test from the
MF> autoconf (ac) namespace but rather a test from the netsnmp
MF> namespace.

Ok, easy change.

>> +       AC_MSG_CHECKING([[for BIO_dgram_get_peer]])

MF> This looks like it begs for AC_CACHE_CHECK instead of AC_CACHE_VAL but
MF> that rewrite can be postponed.

Probably true.

>> +        AC_TRY_LINK(

MF> TRY_LINK to make sure that the expanded macro can be linked, right? If
MF> not then I think TRY_COMPILE would be enough.

The problem is that TRY_COMPILE doesn't catch missing functions.
Missing functions are found at link time.  (I actually tried it with
COMPILE before I had my "oh duh" moment).

It's an odd case, because it's actually a macro that wraps around an
existing function.  It's functionally this:

#define foo(x,y) bar(new_enum_value, x,y)

Where bar already exists in older code but the foo and new_enum_value
remap only exists in newer versions.

>> +         [#include <openssl/bio.h>],
>> +         [BIO_dgram_get_peer(NULL, NULL);],,
>> +         AC_MSG_ERROR([DTLS support requires a newer version of OpenSSL]))

MF> I would prefer if this error showed up somewhere close to the transport
MF> search code and not down here but if could be moved later.

I was trying to stick with existing convention of testing functions in
the function checking space.  I actually *wanted* to write it up previously.

[I also want a better error message with the minimum version number, but
I don't know it off the top of my head and haven't gone to go look
through all the openssl versions to find where it was introduced.
Probably near 0.9.8m.  Maybe.]
-- 
Wes Hardaker
Please mail all replies to net-snmp-coders@lists.sourceforge.net

------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus 
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to