From: Igor Russkikh <igor.russk...@aquantia.com> Date: Fri, 16 Mar 2018 13:53:44 +0300
> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c > b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c > index 967f0fd..0da480b 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c > +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c > @@ -80,15 +80,14 @@ int hw_atl_utils_initfw(struct aq_hw_s *self, const > struct aq_fw_ops **fw_ops) > static int hw_atl_utils_soft_reset_flb(struct aq_hw_s *self) > { > int k = 0; > - u32 gsr; > + u32 gsr, val; Please preserve the reverse christmas tree ordering (longest to shortest line) for variable declarations here.