From: Igor Russkikh <igor.russk...@aquantia.com> Date: Mon, 19 Mar 2018 14:18:55 +0300
> > Hi David, > > Thanks for the comments. > >>> >>> +unsigned aq_tx_clean_budget = 256; >>> +module_param_named(aq_tx_clean_budget, aq_tx_clean_budget, uint, 0644); >>> +MODULE_PARM_DESC(aq_tx_clean_budget, "Maximum descriptors to cleanup on TX >>> at once"); >>> + >>> static void aq_nic_update_ndev_stats(struct aq_nic_s *self); >> >> Please do not add driver private module parameter knobs like this. >> >> Instead, please use a existing, device agnostic, runtime, >> configuration mechanism to control this. > > I'm not aware of any existing standard way to configure tx cleanup budget. > Many drivers just have it hardcoded via define. Is that what you suggest then? You can hard code it, or find some way to make ethtool support this and therefore make the configuration available generically for all drivers which may want to allow tweaking this.
