From: Igor Russkikh <igor.russk...@aquantia.com>
Date: Fri, 16 Mar 2018 13:53:47 +0300

> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c 
> b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> index ebbaf63..5723f2c 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> @@ -36,6 +36,10 @@ static unsigned int aq_itr_rx;
>  module_param_named(aq_itr_rx, aq_itr_rx, uint, 0644);
>  MODULE_PARM_DESC(aq_itr_rx, "RX interrupt throttle rate");
>  
> +unsigned aq_tx_clean_budget = 256;
> +module_param_named(aq_tx_clean_budget, aq_tx_clean_budget, uint, 0644);
> +MODULE_PARM_DESC(aq_tx_clean_budget, "Maximum descriptors to cleanup on TX 
> at once");
> +
>  static void aq_nic_update_ndev_stats(struct aq_nic_s *self);

Please do not add driver private module parameter knobs like this.

Instead, please use a existing, device agnostic, runtime,
configuration mechanism to control this.

Thank you.

Reply via email to