Jeff Garzik wrote:
Auke Kok wrote:
pci_enable_msi failure is a normal event so we should not print any error.
Going over the code I spotted a missing pci_disable_msi() leak when irq
allocation fails. The whole code also needed a cleanup, so I combined the
two different calls to pci_request_irq into a single call making this
look a lot better.
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Cc: H. Peter Anvin <[EMAIL PROTECTED]>
Looks OK, but compounds (and highlights) another problem: you shouldn't
be adding CONFIG_PCI_MSI ifdefs to the code. MSI support is properly
set up in the headers to enable working code even if CONFIG_PCI_MSI is
disabled.
Revise your patch to remove CONFIG_PCI_MSI tests, and I'll include it
straightaway.
OK, on its way.
Thanks.
Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
