Hello,
Thank you very much for your review and integration of work. And
sorry to not have answered you sooner. Time flies very fast those
days…
My other patches are almost independent. I took time to rebase my
branch on the last state of master, if one want to have a look on
them? I explain bellow what they are about.
-
https://git.umaneti.net/netsurf/commit/?h=french-translation&id=f0e7fe3b9f30d6a5fce9c76b28b01db88af11092
This one is completely independent and fix a little typo in
content/fetchers/about/certificate.c (i.e. replace Privince by
Province in the certificate display UI). It also changes
a little the html used to display the nice version of the
certificate date: it ensure the page will be rendered as UTF-8,
what will avoid to display garbage characters if translation
contains non-ascii chars (accent…).
-
https://git.umaneti.net/netsurf/commit/?h=french-translation&id=88ddca04133f24d872db2e4fb9a68c85f0ad285f
This one make it possible to translate the "page info" widget
(the drawer opened by clicking on the netsurf icon or the
padlock to the left of the current uri in the uri bar). In the
same time I propose the first translated string for English
(extracted from previous source code), french (my language) and
some italian string available for the same context at other
place.
-
https://git.umaneti.net/netsurf/commit/?h=french-translation&id=5dc7e57897e47617d5a38adbb3892eebc7c6c465
https://git.umaneti.net/netsurf/commit/?h=french-translation&id=8fcca14770612a1fa838d24aa6e3275e46a971d1
https://git.umaneti.net/netsurf/commit/?h=french-translation&id=2614225923d83f46215c13c249ee7d4679373138
Those 3 commits should be added in this order to avoid conflicts
in fatmessage. They allow some forgotten part of the gtk3
frontend to be translated. Each commit is for a specific
page/widget and directly propose the missing labels for
fatmessage. I reused a lot of label from other frontends.
Let me know if you prefer those patch to be send differently, or
to propose changes on them.
Again, thank you very much for all your hard work!
Étienne
mardi 05 mars 2024 à 23:18, [email protected] a écrit :
On 19/02/2024 15:12, Étienne Deparis wrote:
Hi there,
Since a few weeks I’ve been working on improving the french
translation
of the browser.
Being a Linux user, I’ve been more involved in the gtk3
frontend,
however I tried to also review strings for other frontends as
well. What
I mean is that I’ve only take care to compile and visually
check the
result of my changes with a gtk3 build, and thus cannot
guarantee my
other fixes respect the display on other systems (utf8 support,
string
length, wording habbit…). I’d be very happy to improve my copy
with any
feedback.
You can find these changes under the two following patches (may
be
applied in any order):
- for FatMessages:
https://git.umaneti.net/netsurf/patch/?id=a95d5cabb787a9b6116045d334bb0781022a65ab
- for builtin html pages:
https://git.umaneti.net/netsurf/patch/?id=0169b12fc8ca2ea9607da8465817b398f999980b
Thank you for these -- they have been applied in:
https://git.netsurf-browser.org/netsurf.git/commit/?id=5bb2e9de3c3787d9425c1c8ba39802c75711c380
and
https://git.netsurf-browser.org/netsurf.git/commit/?id=583ec7268083fa2f4005067e0314ff9a56e62664
respectively.
I also maintain a branch (including the previous patches) with
other
translation related improvement (like allowing the translation
of the
gtk3 history, cookies and bookmark windows, or the infopage
widget).
Let me know if I can already transmit those patches as well or
if you
prefer digest them one at a time (all my changes are in atomic
commit,
but order might be import).
If they're independent of each other, by all means send them
over
as-is. Alternatively, if there are ordering constraints, let us
know and
I expect we can work with that, too.
Many thanks,
John-Mark.
