Paul Durrant wrote:
On 4/17/07, Garrett D'Amore <[EMAIL PROTECTED]> wrote:
I'd like to have folks review the work at
http://cr.grommit.com/~gdamore/dmfe_gldv3/webrev
Garrett,
I had a look at your code and it looks fine; you may want to double
check the locking though since Nemo's and GLD's locking are different
in a few places.
Paul
Hmm.... I figured the same rules apply... don't hold any locks when
calling any of Nemo's functions. (That's the normal GLD rule.) Given
that rule, all other locks are "leaf" locks, at least from the
perspective of code outside of the driver.
The only places dmfe calls into the mac layer are, mac_rx,
mac_link_update, and mac_tx_update. At each of these points, dmfe is
not holding any locks whatsoever.
I'm pretty sure therefore that its correct.
-- Garrett
_______________________________________________
networking-discuss mailing list
[email protected]
