Sebastien Roy wrote:
Garrett D'Amore wrote:
I've gone ahead and done a conversion of dmfe to GLDv3 (nemo). I
actually have a dmfe device on SPARC (in this case its on a SPARC
laptop), so I figured this would be beneficial.
I'd like to have folks review the work at
http://cr.grommit.com/~gdamore/dmfe_gldv3/webrev
This is refreshing. :-) Only a couple of comments:
Thanks.
usr/src/uts/sun4u/dmfe/Makefile
* No Comments
usr/src/uts/sun4u/io/dmfe/dmfe_main.c
* 33: is there no longer any kind of version number displayed by modinfo
for dmfe?
Yes. There was some consensus that the version numbers displayed by
modinfo were something short of useless, and that they would eventually
be removed. Rather than continue to update the modinfo version string,
I'm proactively removing it as I happen to touch relevant code.
* 214: the dmfe_m_getcapab function unconditionally always returns
B_FALSE for all capabilities, so I'm wondering what the utility is in
providing an MC_GETCAPAB entrypoint at all for this driver.
Almost none. :-) Except that it documents that a) I considered adding
one, and b) what kinds of capabilities can be added in the near future.
I expect I'll probably add multiaddress support shortly enough. (Mostly
I have to set up a test environment to test it, which is why I didn't
just do it now.)
* 596, 599: Why comment those out? You can still keep track of these
stats in dmfe_t even if GLDv3 doesn't yet ask you for these values,
right?
Actually, I've fixed this, now that GLDv3 will be able to report them.
See PSARC 2007/220. :-)
* 1158: Without context about pre-existing code having once been there
to process VLAN headers, this comment seems odd. I'd just blow this
comment away.
Okay.
* 1349: cstyle; indent by 4.
Okay.
usr/src/uts/sun4u/io/dmfe/dmfe_mii.c
* No Comments
usr/src/uts/sun4u/sys/dmfe_impl.h
* No Comments
-Seb
Thanks for the review.
-- Garrett
_______________________________________________
crossbow-discuss mailing list
[EMAIL PROTECTED]
http://opensolaris.org/mailman/listinfo/crossbow-discuss
_______________________________________________
networking-discuss mailing list
[email protected]
