On 24/05/07, Garrett D'Amore <[EMAIL PROTECTED]> wrote:
b) ease of implementation. i can print the link up/down state
without having to inquire the details from the driver, which avoids a
potential recursive lock situation if the driver happens to be careless
with the context from which it calls mac_link_update().
In the future, it may be a nice thing to provide media-specific extended
information in mac_link_update(), such as speed, duplex (for 802.3),
ssid/bssid (for 802.11) etc.
Given that Nemo is still private it may be best to ensure that
mac_link_update() *is* called from a sensible locking context for all
drivers then you *can* enquire about other link info.
Personally I prefer information to be available from a single
definitive source. Thus I would prefer that mac_link_update() actually
carries *no* information about link state at all; it merely says that
a client needs to go and check the link because something happened.
All relevant link information is available from the mac_stat_get()
call so this can be used to retrieve relevant information.
Paul
--
Paul Durrant
http://www.linkedin.com/in/pdurrant
_______________________________________________
networking-discuss mailing list
[email protected]
