On 25/05/07, Garrett D'Amore <[EMAIL PROTECTED]> wrote:
Paul Durrant wrote:
> On 24/05/07, Garrett D'Amore <[EMAIL PROTECTED]> wrote:
>>
>> That's the way it is implemented in my workspace right now.... its just
>> that the logging functionality doesn't provide anything other than the
>> the up/down notification. Details have to be retrieved from dladm or
>> kstats.
>>
>
> Indeed, and I think up/down is too much information. That should also
> be retrieved from stats.
Again, I think there is historical value here. (Of two kinds. First
there is the historical practice of having the data in the logs.
That was not my point. My point was that the mac_link_update() call
should be passed no information other than the mac_handle_t. The
consumer of the notification should be the one who decides how much
information to dig for since it may only be interested that something
happened but not necessarily care what it is; hence any extra
information passed by the driver may be wasted.
For an event consumer that wants information such as duplex, speed,
media, etc. the statistics interface is there to supply as much
information as is required.
Paul
--
Paul Durrant
http://www.linkedin.com/in/pdurrant
_______________________________________________
networking-discuss mailing list
[email protected]
