Erik Nordmark wrote: >The CGTP (Carrier Grade Transport Protocol) support in IP needs to be >extended to allow separate configuration of CGTP for different >exclusive-IP zones. > >This is: >PSARC 2007/250 CGTP for IP Instances >6572777 Need CGTP hooks version 3 to allow per-IP instance hooks > >The webrev is at: >http://cr.grommit.com/~nordmark/cgtpv3/ > >Who can code review this for me? > >
ip.c - ip_cgtp_filter_register() This function should check that ipst->ips_ip_cgtp_filter_ops is actually NULL before returning success, else the code in ip_cgtp_filter_unregister(), which just assigns NULL back into ips_ip_cgtp_filter_ops is technically incorrect (there's no assurance that it was NULL to start with.) There should be at least an ASSERT() in _register() that _ops is NULL. It's conceivable that the code using this should be using this after a successful call to the is_registered() function first, but I'm not sure that this is sufficient? Darren _______________________________________________ networking-discuss mailing list [email protected]
