[EMAIL PROTECTED] wrote:
> ip.c - ip_cgtp_filter_register()
> This function should check that ipst->ips_ip_cgtp_filter_ops
> is actually NULL before returning success, else the code
> in ip_cgtp_filter_unregister(), which just assigns NULL
> back into ips_ip_cgtp_filter_ops is technically incorrect
> (there's no assurance that it was NULL to start with.)
> There should be at least an ASSERT() in _register() that
> _ops is NULL.
Good point. I'll add a check and return EALREADY if it is already
registered.
Erik
> It's conceivable that the code using this should be using this
> after a successful call to the is_registered() function first, but
> I'm not sure that this is sufficient?
>
> Darren
>
_______________________________________________
networking-discuss mailing list
[email protected]
