I'm fixing the following PPP bugs in OpenSolaris:
4937465 sppp_lrput() can race against sppp's I_UNLINK logic and
panic on victory
4959338 sppptun_urput() assumes well-formed dlpi messages
4973860 System panic occured in spppcomp:bsd_compress
6198878 sppptun never re-enables upper streams if lower stream flow
controls
6271013 sppp: unknown protocol error message
6630377 ugly debug macros in sppptun have got to go
I'd appreciate getting comments on these changes, particularly from
anyone with either PPP or STREAMS experience ("you know who you
are"). The webrev is here:
http://cr.opensolaris.org/~carlsonj/webrev-4937465/
http://zhadum.east/ws/carlsonj/4937465-fix/webrev/
I've done unit tests for each one of the fixes as well as manual
stress tests using netperf and PPPoE. I'm working on running the
automated tests now.
Given the upcoming holiday, I'll wait for review comments until at
least November 30th, unless someone asks for more time. I'm targeting
build 80 (opens 11/28 and closes 12/10).
--
James Carlson, Solaris Networking <[EMAIL PROTECTED]>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
_______________________________________________
networking-discuss mailing list
[email protected]
