James Carlson wrote:
> I'd appreciate getting comments on these changes, particularly from
> anyone with either PPP or STREAMS experience ("you know who you
> are"). The webrev is here:
The changes look good. Two nits you can feel free to ignore:
usr/src/uts/common/io/ppp/sppp/sppp.c
* 708: This is the only call site for sppp_mproto(). You might as well
make sppp_mproto() return void.
usr/src/uts/common/io/ppp/spppcomp/bsd-comp.c
* 149: DS_INIT means "done initializing", and not "in the process of
initializing". Perhaps "DS_INITDONE" would be more descriptive?
-Seb
_______________________________________________
networking-discuss mailing list
[email protected]
