James Carlson wrote:
> Sebastien Roy writes:
>> James Carlson wrote:
>>> I'd appreciate getting comments on these changes, particularly from
>>> anyone with either PPP or STREAMS experience ("you know who you
>>> are"). The webrev is here:
>> The changes look good. Two nits you can feel free to ignore:
>>
>> usr/src/uts/common/io/ppp/sppp/sppp.c
>>
>> * 708: This is the only call site for sppp_mproto(). You might as well
>> make sppp_mproto() return void.
>
> I almost did that, but then sppp_mproto (over in sppp_dlpi.c;
> currently untouched) wants to return the result from pi_funcp, which
> means a much bigger change, with lower benefit than just getting the
> STREAMS entry points right.
>
> It's a sweater thread-pull issue. I'll do it if you insist, but it
> seemed like too much change and not enough benefit to me.
You can leave it, that's fine with me.
-Seb
_______________________________________________
networking-discuss mailing list
[email protected]
