On Mon, Feb 02, 2009 at 04:03:37PM -0500, James Carlson wrote:
> > It does seem weak, no? Fixed. The IPPROTO_ROUTING case is extra annoying,
> > but also contorts appropriately now.
>
> The same comment is still at line 8840 ... I don't think it applies
Yanked.
> anymore. In fact, given the code at lines 8855-8867, it's unclear if
> this code does anything.
It advances along the mblk chain. Consider a (common) case like:
mp1 (IPv4, IPv6) + mp2 (Hop-by-hop, ICMP6)
I start in mp1, and then have to advance to mp2. mp2 will be nice and
aligned, and we have no need for the annoyance of lines 8855-67.
8855-67 guard against real crud like:
mp1 (IPv4, IPV6, one-byte-of-hop-by-hop) + mp2(rest-of-HBH, ICMP6)
> For lines 8856 and 8862, does this code compile? If it does, then
> that's surprising. -= and += shouldn't work when both terms are
> pointers.
I was waiting for an additional review answer before I spun up a local
compile. I now have fixed those two lines with uintptr_t casts, added my
additional review answer (another reviewer suggested static DTrace probes in
bad-packet cases), and updated the webrev.
Thanks!
Dan
_______________________________________________
networking-discuss mailing list
[email protected]
