Dan McDonald writes: > On Mon, Feb 02, 2009 at 04:03:37PM -0500, James Carlson wrote: > > anymore. In fact, given the code at lines 8855-8867, it's unclear if > > this code does anything. > > It advances along the mblk chain. Consider a (common) case like: > > mp1 (IPv4, IPv6) + mp2 (Hop-by-hop, ICMP6) > > I start in mp1, and then have to advance to mp2. mp2 will be nice and > aligned, and we have no need for the annoyance of lines 8855-67.
Ah, ok. That makes sense. > > For lines 8856 and 8862, does this code compile? If it does, then > > that's surprising. -= and += shouldn't work when both terms are > > pointers. > > I was waiting for an additional review answer before I spun up a local > compile. I now have fixed those two lines with uintptr_t casts, added my > additional review answer (another reviewer suggested static DTrace probes in > bad-packet cases), and updated the webrev. OK. -- James Carlson, Solaris Networking <[email protected]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
