Am 17.06.2014 16:50, schrieb Michael Biebl:

> I also noticed that you implemented pre-up and pre-down in the
> dispatcher and that there are now dedicated directories in
> /etc/NetworkManager/dispatcher.d/pre-down.d
> /etc/NetworkManager/dispatcher.d/pre-up.d
> 
> That seems a bit inconsistent with how currently dispatcher scripts are
> handled, i.e. the "phase" is passed as $2 to scripts in
> /etc/NetworkManager/dispatcher.d/
> Is there any reason why you didn't just extend the existing up/vpn-up,
> down/vpn-down?

This also leads to this error message from the dispatcher:
Jun 17 17:03:13 pluto nm-dispatcher[14151]: Cannot execute
'/etc/NetworkManager/dispatcher.d/pre-down.d': not a regular file.
Jun 17 17:03:13 pluto nm-dispatcher[14151]: Cannot execute
'/etc/NetworkManager/dispatcher.d/pre-up.d': not a regular file.



While I'm not generally opposed to the idea of using .d directories, I
think what's important is consistency. Either we use .d directories for
all available actions, or we use a single directory and pass the action
as $2.

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
networkmanager-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Reply via email to