On Tue, 2014-06-17 at 20:31 +0200, Michael Biebl wrote: > Am 17.06.2014 18:31, schrieb Dan Williams: > > Separate directories were used for pre-up/pre-down because these events > > block state changes internally. NM will not advance a device from > > ACTIVATED -> DISCONNECTED (pre-down) or IP_CHECK -> SECONDARIES (pre-up) > > until all the scripts execute. > > > > Unfortunately, many scripts don't bother checking the action and just > > run stuff, and the goal was to ensure that couldn't adversely impact the > > user experience on upgrade. > > I checked the complete Debian archive and there is only one package > installing a dispatcher script which doesn't check for the $action > parameter, so is potentially affected. Easy to fix. > > You were talking about many scripts doing it wrong? Do you have a list > of such packages/scripts?
(without having any numbers at hand) I would suspect that many scripts are just cooked-up by users and not part of other packages. Further I would guess that these scripts are often of lower quality. > I get where you're coming from, but there will always be ways for people > to shoot themselves in the foot and I'd rather prefer consistency here > then convenience for lazy script writers. I still think, that these separate directories are a good idea. Also note that all the scripts that exists to date don't expect these events. They existed without them for years. So probably most script will continue not to do anything useful with then (if not harmful). By having separate directories we actually save such invocations (because NM will not even make the call if the directory contains no scripts). I am trying to make a performance argument here, although arguably it might not matter to call a few scripts needlessly. Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
