On Fri, 2016-11-25 at 19:22 +0100, Francesco Giudici wrote: > > the rebased and fixed branch is: > fg/c-e-ethernet-link2
Hi Francesco,
"duplex ? : NULL" is not necessary :)
maybe the link-negotiation part should be at the bottom of the page.
It seems that "Device" is more important, and should be on top.
When a user selects only speed or duplex, then the "Save" button should
be disabled. You have to let verification of the page fail.
The tooltip of the UI fields should say something helpful.
Currently, if the user toggles the autoneg checkbox, the duplex|speed
setting stay unchanged at whatever they are, which is good.
If autoneg is enabled, it is also good to see there the values
"Automatic" for duplex|speed (although grayed out).
If the checkbox is disabled, can we however change the "Automatic" text
to "Preserve" and show a different tooltip?
like
[x] Automatic
Speed "Automatic" (or one of the 10* values)
Duplex "Automatic" (or one of full/half)
[ ] Automatic
Speed "Preserve" (or one of the 10* values)
Duplex "Preserve" (or one of full/half)
Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
