On 28.11.2016 16:48, Francesco Giudici wrote:
>
>
> On 25/11/2016 20:57, Thomas Haller wrote:
>>>
>>> "duplex ? : NULL" is not necessary :)
>
> Removed, thanks :-)
>
>>>
>>> maybe the link-negotiation part should be at the bottom of the page.
>>> It seems that "Device" is more important, and should be on top.
>
> You are right.. at least under "Device" is a must.
> Moved bottom.
>
>>> ...
>>>
>>> The tooltip of the UI fields should say something helpful.
>
> Added tooltips for speed and duplex. This should help making more clear
> that their values are required only when "static" link negotiation is
> selected (implicitly)
>
>>>
>>> Currently, if the user toggles the autoneg checkbox, the duplex|speed
>>> setting stay unchanged at whatever they are, which is good.
>>
>> ah no, checking autonegotiation, resets the Combo-boxes to "Automatic".
>> Hm, OK, that is a possiblity.
>> Maybe instead not reset the comboboxes, only disable them?
>>
>> Or maybe best: temporarily reset them to "Automatic", but if the user
>> unchecks the checkbox again, restore the previous value (possibly
>> "Preserve").
>
> Well, as is the default and I think should be immediately clear how to
> achieve that, I added an "Ignore" explicit option besides the "Auto"
> one. In this way we could get rid of the "unset" options for duplex and
> speed in the dropdown lists (DEFAULT/PRESERVE). When both "Auto" and
> "Ignore" are unchecked "Speed" and "Duplex" are enabled and can take
> only valid values.
>
> Updated fg/c-e-ethernet-link2
>
c-e: fix typo
fg/c-e-ethernet-link2 branch
---
src/connection-editor/ce-page-ethernet.ui | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connection-editor/ce-page-ethernet.ui
b/src/connection-editor/ce-page-ethernet.ui
index 93c293a..b03c8b8 100644
--- a/src/connection-editor/ce-page-ethernet.ui
+++ b/src/connection-editor/ce-page-ethernet.ui
@@ -354,7 +354,7 @@
<property name="can_focus">True</property>
<property name="receives_default">False</property>
<property name="use_underline">True</property>
- 1<property name="xalign">0</property>
+ <property name="xalign">0</property>
<property name="draw_indicator">True</property>
</object>
<packing>
--
2.7.4
_______________________________________________
networkmanager-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/networkmanager-list
