On Fri, 2016-11-25 at 20:55 +0100, Thomas Haller wrote: > On Fri, 2016-11-25 at 19:22 +0100, Francesco Giudici wrote: > > > > the rebased and fixed branch is: > > fg/c-e-ethernet-link2 > > Hi Francesco, > > > "duplex ? : NULL" is not necessary :) > > > > maybe the link-negotiation part should be at the bottom of the page. > It seems that "Device" is more important, and should be on top. > > > When a user selects only speed or duplex, then the "Save" button > should > be disabled. You have to let verification of the page fail. > > > The tooltip of the UI fields should say something helpful. > > > Currently, if the user toggles the autoneg checkbox, the duplex|speed > setting stay unchanged at whatever they are, which is good.
ah no, checking autonegotiation, resets the Combo-boxes to "Automatic". Hm, OK, that is a possiblity. Maybe instead not reset the comboboxes, only disable them? Or maybe best: temporarily reset them to "Automatic", but if the user unchecks the checkbox again, restore the previous value (possibly "Preserve"). Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
