Nicolas Williams wrote: > On Thu, Apr 30, 2009 at 10:53:50AM -0700, Jordan Brown wrote: >> The vast majority of the changes are to make the file pass cstyle and lint. > > That became necessary only once it became necessary to not generate this > file every time. It's NOT necessary to make code generators generate > cstyle-clean code.
Yes... but we have observed in real life at least one case where people had to hand-tweak the generated code, which changes the equation considerably. > I don't think you should go touch rpcgen to make it generate > cstyle-clean code. Any reason other than development+test time and associated risk? > Ah! Then we should interpose on syslog() or punt. As you know from previous discussions, I don't like interposing on random libc functions. Yes, it can be done sort of safely, but it seems like an opportunity for problems and confusion. >> I'd like to add a feature to rpcgen to allow the user to customize message >> handling, so that the generated file can be used directly and there is no >> need to hand-tweak it and check the file into the repository. > > That's fine too, but if it's easier to punt or interpose on syslog() > then do that. It wasn't hard, and (as may be obvious from the fact that I raised the question) I liked it better.
