DENIEL Philippe wrote on Wed, Apr 29, 2015 at 10:10:04AM +0200: > - gerrit runs automated test on it (like checkpatch) and verify the > patches
Gerrit doesn't run anything. EVERYONE should add triggers to run tests automatically - triggers are 100% "private" (just run ssh gerrit stream-events and read the pipe) Jenkins can do this natively (with the gerrit plugin), there's a script in src/script/gerrit that can serve as example if you want to redo it yourself. > - we should provide big and squashed patches, one per feature. For > example, CEA will soon push a rework of FSAL_HPSS, this will be a single > commit. We do that for HPSS because the FSAL is old, has been pruned out a while ago, and currently doesn't checkpatch/individual patches won't checkpatch. That's purely selfish and we don't actually expect anyone to review that code anyway, since no-one in the active community will use it - it's pretty far from normal workflow submitting... I believe patches should be kept reasonably small for review, really, but "reasonably small" is subjective and flexible. What we really need is for more people to review and that's not going to improve if we push big hunks :) -- Dominique ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
