DENIEL Philippe [philippe.den...@cea.fr] wrote: > issue. If I do a big patch or 10 small ones, all of my changed files > will have to be reviewed, which does have no impact on the workload. In > fact, one big patch is a cool situation : it is easy to rebase, and it > depends only on stuff already pushed and landed. If I publish 5 patches, > what if patch 1, 2 and 3 merge fine, but 4 produce a conflict ? How > could I rebase 4 without touch 1,2 and 3 ? This leads to a dependencies > maze, and this is precisely the situation we fell into.
There is no doubt that a "well" split patchset is easier to review. I did rebase mega patches from others (that happens when you pick up someone else's work) in the past and it is a PITA. Even if it is my code, I find it lot easier to rebase small patches than one big patch. Regards, Malahal. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
