Bill, Well, something broke. The defined model for fetching the ntirpc src did not depend on the default branch of the upstream repository, nor on its top commit, we made the commit explicit. I tend to think that's preferable to freezing a branch.
There hasn't been official use of linuxbox2/ntirpc.git by nfs-ganesha checkouts for, iirc, 3 years. I agree it's duplex-12 branch should, if it is updated, only contain commits seen on upstream duplex-12. But please do not assume we are keeping it up to date--because no one expected to be relying on it. This is you inventing a rule, and complaining about me breaking it. Please tone down the rhetoric a bit. These are changes on a development branch. If you want to vent, use the provided IRC channel ;). Matt -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309 ----- Original Message ----- > From: "William Allen Simpson" <william.allen.simp...@gmail.com> > To: "Matt W. Benjamin" <m...@cohortfs.com> > Cc: nfs-ganesha-devel@lists.sourceforge.net > Sent: Sunday, October 4, 2015 7:37:52 AM > Subject: Re: [Nfs-ganesha-devel] WARNING to all ntirpc developers > > Dan's cmake completely overwrites src/libntirpc *IN PLACE* the > next time you make ganesha. > > If you have any changes pending, save/push your commits > somewhere before your next compile after updating. > > > On 10/3/15 8:32 AM, Matt W. Benjamin wrote: > > ----- "William Allen Simpson" <william.allen.simp...@gmail.com> wrote: > >> Frank, could you please change nfs-ganesha/ntirpc to default > >> branch duplex-12? Matt forgot, and I've reminded him twice. > > > > Ok, fine, I've done this. I don't think this was a blocker. > > > No submodule to checkout a specific commit, so defaulted to > duplex-11. duplex-11 has missing/moved SVCXPRT symbols, etc. > > Complete showstopper. Glad it's fixed now. > > > >> Dan, you forgot to push your dang/ntirpc external to both > >> linuxbox2/ntirpc > > > > Not assured by us to be kept at parity with the upstream repo, it's a > > 3rd-party repo, wrt nfs-ganesha. > > > > and nfs-ganesha/ntirpc duplex-12 > > > I've been treating it as the official ntirpc development site. > > Should it be abandoned, then? > > > > I merged Dan's PR Thursday AM eastern. What exactly is not merged? > > > commit f9ec4b8e37ac59f81b5feaac9f4151686acd61ac > Author: Daniel Gryniewicz <d...@redhat.com> > Date: Thu Oct 1 11:32:51 2015 -0400 > > Fix RDMA build > > Signed-off-by: Daniel Gryniewicz <d...@redhat.com> > > commit 93fc447716624bd6c92b3b11b4c6b574d9b2aaa7 > Merge: c4e264a 669383d > Author: Matt Benjamin <mbenja...@redhat.com> > Date: Thu Oct 1 08:35:45 2015 -0400 > > Merge pull request #4 from dang/external > > Allow ntirpc to be used as a CMake external > > > > -- RDMA > >> cmake and compile fail. > > > > Um... Will revisit next week, I guess. > > > Goody. > > > ------------------------------------------------------------------------------ > _______________________________________________ > Nfs-ganesha-devel mailing list > Nfs-ganesha-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
