Nothing is overwritten in your source tree, even if you build ganesha
in your source tree.  The ntirpc checkout happens in the *build* tree,
in a subdir specific to building ntirpc.

In addition, a *specific* commit hash is checked out, not the head of any tree.

Dan

On Sun, Oct 4, 2015 at 7:32 PM, William Allen Simpson
<william.allen.simp...@gmail.com> wrote:
> Goodness gracious, I hate top-posting!  Merged with original.
>
> On 10/4/15 10:37 AM, Matt Benjamin wrote:
>>> >From: "William Allen Simpson"<william.allen.simp...@gmail.com>
>>> >To: "Matt W. Benjamin"<m...@cohortfs.com>
>>> >Cc:nfs-ganesha-devel@lists.sourceforge.net
>>> >Sent: Sunday, October 4, 2015 7:37:52 AM
>>> >Subject: Re: [Nfs-ganesha-devel] WARNING to all ntirpc developers
>>> >
>>> >Dan's cmake completely overwrites src/libntirpc*IN PLACE*  the
>>> >next time you make ganesha.
>>> >
>>> >If you have any changes pending, save/push your commits
>>> >somewhere before your next compile after updating.
>>> >
>> Well, something broke.  The defined model for fetching the ntirpc src did 
>> not depend on the default branch of the upstream repository, nor on its top 
>> commit, we made the commit explicit.  I tend to think that's preferable to 
>> freezing a branch.
>>
> That was the submodule version.  Now gone.
>
> We will be dependent on freezing a branch.
>
>
>>> >On 10/3/15 8:32 AM, Matt W. Benjamin wrote:
>>>> > >----- "William Allen Simpson"<william.allen.simp...@gmail.com>  wrote:
>>> >I've been treating it as the official ntirpc development site.
>>> >
>>> >Should it be abandoned, then?
>>> >
>> There hasn't been official use of linuxbox2/ntirpc.git by nfs-ganesha 
>> checkouts for, iirc, 3 years.
>
> nfs-ganesha checkouts of linuxbox2/ntirpc.git were not
> mentioned in my message(s).
>
>
>> I agree it's duplex-12 branch should, if it is updated, only contain commits 
>> seen on upstream duplex-12.  But please do not assume we are keeping it up 
>> to date--because no one expected to be relying on it.  This is you inventing 
>> a rule, and complaining about me breaking it.
>>
> In the past, things were always pushed to linuxbox2/ntirpc before
> they were pushed by you to nfs-ganesha/ntirpc.  That was your rule,
> communicated to me for my work.
>
> All development branches were off of the linuxbox2 master, currently
> designated "duplex-12".  Based upon your response, I'll stop using
> linuxbox2/ntirpc.
>
> What gerrit branch is being used to push proposed ntirpc changes?
>
>
>> Please tone down the rhetoric a bit.  These are changes on a
>> development branch. [...]
>>
> These are changes on the -rc branch.  We agreed on the phone
> call (that you missed) to warn everybody that their submodule
> would be overwritten.  It's kinda important! :)
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

------------------------------------------------------------------------------
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to