Instructions are here:
https://github.com/nfs-ganesha/nfs-ganesha/wiki/DevPolicy#Pushing_to_gerrit
Daniel
On 08/08/2017 11:37 AM, Pradeep wrote:
Thanks Daniel & Frank for confirming. How do I submit a patch? Here is
the diff:
diff --git a/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c
b/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c
index e6d7be4..ee5f6e2 100644
--- a/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c
+++ b/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c
@@ -64,9 +64,9 @@
CONF_ITEM_UI32("Dir_Max", 1, UINT32_MAX, 65536,
mdcache_parameter, dir.avl_max),
CONF_ITEM_UI32("Dir_Chunk", 0, UINT32_MAX, 128,
- mdcache_parameter, dir.avl_detached_mult),
-CONF_ITEM_UI32("Detached_Mult", 1, UINT32_MAX, 1,
mdcache_parameter, dir.avl_chunk),
+CONF_ITEM_UI32("Detached_Mult", 1, UINT32_MAX, 1,
+ mdcache_parameter, dir.avl_detached_mult),
CONF_ITEM_UI32("Entries_HWMark", 1, UINT32_MAX, 100000,
mdcache_parameter, entries_hwmark),
CONF_ITEM_UI32("Chunks_HWMark", 1, UINT32_MAX, 100000,
On Tue, Aug 8, 2017 at 5:58 AM, Daniel Gryniewicz <d...@redhat.com
<mailto:d...@redhat.com>> wrote:
On 08/07/2017 11:24 PM, Pradeep wrote:
It appears that the commit 440a048887c99e17e2a582e8fb242d5c0a042a79
has reversed two mdcache config parameters and as a result the
default
value of dir.avl_chunk became 1 from 128. Is this intentional?
Ideally
the "Dir_Chunk" should map to dir.avl_chunk and "Detached_Mult"
should
map to dir.avl_detached_mult, isn't it?
CONF_ITEM_UI32("Dir_Chunk", 0, UINT32_MAX, 128,
mdcache_parameter, dir.avl_detached_mult),
CONF_ITEM_UI32("Detached_Mult", 1, UINT32_MAX, 1,
mdcache_parameter, dir.avl_chunk),
This looks wrong. Good catch. This is also broken on 2.5, so the
fix will need to be backported. Do you want to submit a patch, or
should I?
Daniel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
<mailto:Nfs-ganesha-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
<https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
