Shantonu Sen <[EMAIL PROTECTED]> writes:
> Just to close out this thread, I have committed a getpass() which Glenn
> Burkhardt and I have been working on. It solves the problem of other
> programs interfacing with nmh, such as exmh, as well as guaranteeing the
> implementation of that function.
>
> i have personally compiled and used it on linux (redhat 6.1 with
> glibc2.1.2), solaris 8, netbsd 1.4.2, IRIX 6.5. it's main dependency is on
> termios.h, so please tell me if this causes any problems.
Works fine on AIX 4.1.5.0.01. I cleaned up four compiler warnings produced
by gcc -Wall. One of them required adding an #include of <stdlib.h>, and
this required me to change getpass() to take a const char* rather than a
char*, to match the system prototype. Is this how getpass() is declared
everywhere? If not, we'll need to add autoconf support to check the
declaration or (preferably) change this function name to be nmh_getpass().
I notice the memory allocated by calloc() is leaked. Not that big a deal
for nmh's short-running programs, I guess, but it might at least be worth a
comment acknowledging the leak and giving the justification.
> as far as licenses, the code started out from the netBSD codebase, but I
> really hacked on it a LOT to get it to do what i wanted. hopefully this
> should be okay.
The copyright notice sort of implies that we're using the unchanged
version. We should probably add "Portions of this code are" to the
beginning, eh?
> on a separate note, does anyone have objections to cleaning out
> MACHINES? it really has a lot of useless crap, like the following:
>
> *** No longer necessary ***
> *** This test has been updated and should work now ***
>
> if these are no longer issues, they should not be included in the file,
> since it only serves to confuse users on non-issues.
By all means. Ideally we'd be able to get rid of MACHINES altogether.
-----------------------------------------------------------------------
Dan Harkless | To prevent SPAM contamination, please
[EMAIL PROTECTED] | do not post this private email address
SpeedGate Communications, Inc. | to the USENET or WWW. Thank you.
