Fabian Deutsch has posted comments on this change. Change subject: Allow for bonding options in auto install ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33348/1/src/ovirt/node/config/defaults.py File src/ovirt/node/config/defaults.py: Line 517: cfg.update({"slaves": (cfg["slaves"].split(",") if cfg["slaves"] Line 518: else [])}) Line 519: cfg.update({"options": (" ".join(cfg["options"].split(",")) Line 520: if cfg["options"] Line 521: else "mode=balance-rr miimon=100")}) No, we don't suggest default options, it's completely left to the administrator. Line 522: return cfg Line 523: Line 524: def configure_no_bond(self): Line 525: """Remove all bonding -- To view, visit http://gerrit.ovirt.org/33348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice355b709d5e1515226fe211786b13489f293d0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
