Fabian Deutsch has posted comments on this change. Change subject: Allow for bonding options in auto install ......................................................................
Patch Set 2: (1 comment) See my inline comments http://gerrit.ovirt.org/#/c/33348/2/scripts/ovirt-init-functions.sh.in File scripts/ovirt-init-functions.sh.in: Line 689: ;; Line 690: bond_setup=*) Line 691: i=${i#bond_setup=} Line 692: eval $(printf $i|awk -F: '{print "bond_name="$1; print "bond_slaves="$2; print "bond_options="$3;}') Line 693: bond_options=${bond_options//,/ } Please replace the tab at the beginning of the line and change the bash expression to: bond_options=${bond_options/,/ } Line 694: ;; Line 695: hostname=*) Line 696: hostname=${i#hostname=} Line 697: ;; -- To view, visit http://gerrit.ovirt.org/33348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice355b709d5e1515226fe211786b13489f293d0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
