Fabian Deutsch has posted comments on this change. Change subject: Allow for bonding options in auto install ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33348/4/scripts/ovirt-init-functions.sh.in File scripts/ovirt-init-functions.sh.in: Line 687: ;; Line 688: bond_setup=*) Line 689: i=${i#bond_setup=} Line 690: eval $(printf $i|awk -F: '{print "bond_name="$1; print "bond_slaves="$2; print "bond_options="$3;}') Line 691: bond_options=${bond_options/,/ } it should be =${bond_options//,/ } to replace all occurrences of , with " ". $ export B="1,2,3" $ echo ${B/,/ } 1 2,3 $ echo ${B//,/ } 1 2 3 Line 692: ;; Line 693: hostname=*) Line 694: hostname=${i#hostname=} Line 695: ;; -- To view, visit http://gerrit.ovirt.org/33348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice355b709d5e1515226fe211786b13489f293d0d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
