> On Dec 14, 2015, at 6:55 AM, Tom Hughes <[email protected]> wrote: > >> On 14/12/15 11:35, Stephen Gallagher wrote: >> >> I'd actually argue that we probably want to do this whether or not there are >> other tests. (It's always possible that upstream tests run against the >> source directory instead of the installed path, and therefore might not be >> entirely correct) > > Well normally in koji there won't an old version present so that's unlikely. > Plus because node only searches the local node_modules normally it would > still be unlikely to find it. > >> I'd go so far as to say that we should propose a modification to the >> packaging guidelines to state this explicitly. Would you like me to prepare >> a draft? > > Sounds good to me. > > Sometimes modules have extra entry points that can be loaded with variants of > require in which case those could be test loaded as well. >
Could you give me an example of those variants? > Tom > > -- > Tom Hughes ([email protected]) > http://compton.nu/ > _______________________________________________ > nodejs mailing list > [email protected] > http://lists.fedoraproject.org/admin/lists/[email protected] _______________________________________________ nodejs mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
