ctubbsii commented on a change in pull request #332: ACCUMULO-4826 Use the
hadoop3 shaded jars
URL: https://github.com/apache/accumulo/pull/332#discussion_r170411518
##########
File path: minicluster/pom.xml
##########
@@ -154,4 +145,51 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>hadoop2</id>
+ <activation>
+ <property>
+ <!-- Hack around activeByDefault=true not working as we'd want -->
+ <name>!hadoop.profile</name>
+ </property>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-minicluster</artifactId>
+ <optional>true</optional>
+ </dependency>
+ </dependencies>
+ </profile>
+ <profile>
+ <id>hadoop3</id>
+ <activation>
+ <property>
+ <name>hadoop.profile</name>
+ <value>3</value>
+ </property>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client-minicluster</artifactId>
+ <optional>true</optional>
Review comment:
I'm actually very curious whether this optional has any effect, since it's
not clear to me how transitive dependency resolution actually happens for
dependencies declared in profiles (and we're not generating "effective" POMs
based on profiles). It shouldn't hurt, though. I'll make a personal note to
investigate this, unless somebody else knows and can educate me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
