ctubbsii commented on a change in pull request #332: ACCUMULO-4826 Use the 
hadoop3 shaded jars
URL: https://github.com/apache/accumulo/pull/332#discussion_r170411383
 
 

 ##########
 File path: core/pom.xml
 ##########
 @@ -282,5 +277,50 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <id>hadoop2</id>
+      <activation>
+        <property>
+          <!-- Hack around activeByDefault=true not working as we'd want -->
 
 Review comment:
   Not sure this comment makes sense without some explanation as to why we were 
expecting activeByDefault to behave differently than it was documented to 
behave. Might be better to just say that 'this profile is used when not 
otherwise specified'. (EDIT: might also want to borrow from previous wording 
when we had Hadoop 1 and 2 profile)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to