ctubbsii commented on a change in pull request #332: ACCUMULO-4826 Use the
hadoop3 shaded jars
URL: https://github.com/apache/accumulo/pull/332#discussion_r170411239
##########
File path: assemble/bin/bootstrap_config.sh
##########
@@ -383,6 +394,25 @@ elif [[ "${HADOOP_VERSION}" == "IOP4.1" ]]; then
sed -e 's/<!-- HDP 2.2 requirements -->/<!-- HDP 2.2 requirements --><!--/' \
-e 's/<!-- End HDP 2.2 requirements -->/--><!-- End HDP 2.2 requirements
-->/' \
"${CONF_DIR}/$ACCUMULO_SITE" > temp
+ sed -e 's/<!-- Hadoop 3 requirements -->/<!-- Hadoop 3 requirements
--><!--/' \
+ -e 's/<!-- End Hadoop 3 requirements -->/--><!-- End Hadoop 3
requirements -->/' \
+ "${CONF_DIR}/$ACCUMULO_SITE" > temp
+ mv temp "${CONF_DIR}/$ACCUMULO_SITE"
+elif [[ "${HADOOP_VERSION}" == "3" ]]; then
+ sed -e 's/<!-- Hadoop 2 requirements -->/<!-- Hadoop 2 requirements
--><!--/' \
+ -e 's/<!-- End Hadoop 2 requirements -->/--><!-- End Hadoop 2
requirements -->/' \
+ "${CONF_DIR}/$ACCUMULO_SITE" > temp
+ sed -e 's/<!-- HDP 2.0 requirements -->/<!-- HDP 2.0 requirements --><!--/' \
+ -e 's/<!-- End HDP 2.0 requirements -->/--><!-- End HDP 2.0 requirements
-->/' \
+ "${CONF_DIR}/$ACCUMULO_SITE" > temp
Review comment:
This will clobber the contents of temp from the previous sed execution. It's
too bad we didn't just move the file once, and do all the sed calls with the
in-place `-i` flag (but not worth changing in this PR). (EDIT: that is... not
worth changing to use `-i`; the clobbering still needs to be fixed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
