keith-turner commented on a change in pull request #1552: Fix and simplify
TransportCachingIT
URL: https://github.com/apache/accumulo/pull/1552#discussion_r389191801
##########
File path: test/src/main/java/org/apache/accumulo/test/TransportCachingIT.java
##########
@@ -158,7 +124,7 @@ public void testCachedTransport() throws
InterruptedException {
while (fifth == null) {
try {
// Get a cached transport
- fifth = pool.getAnyTransport(servers, true).getSecond();
+ fifth = pool.getAnyTransport(servers.subList(0, 1),
true).getSecond();
Review comment:
If on the first attempt it gets a TTransportException and on the 2nd attempt
it succeeds then it seems like it could become non-null, right? So maybe the
looping is not so sketchy after all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
