milleruntime commented on a change in pull request #1552: Fix and simplify
TransportCachingIT
URL: https://github.com/apache/accumulo/pull/1552#discussion_r389655581
##########
File path: test/src/main/java/org/apache/accumulo/test/TransportCachingIT.java
##########
@@ -148,7 +114,7 @@ public void testCachedTransport() throws
InterruptedException {
while (fourth == null) {
try {
// Get a non-cached transport
- fourth = pool.getAnyTransport(servers, false).getSecond();
+ fourth = pool.getAnyTransport(servers.subList(0, 1),
false).getSecond();
Review comment:
How does getting the same transport from a list of one test anything? The
last ```assertSame``` now doesn't seem like it is testing anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
