keith-turner commented on a change in pull request #1552: Fix and simplify
TransportCachingIT
URL: https://github.com/apache/accumulo/pull/1552#discussion_r389799015
##########
File path: test/src/main/java/org/apache/accumulo/test/TransportCachingIT.java
##########
@@ -148,7 +114,7 @@ public void testCachedTransport() throws
InterruptedException {
while (fourth == null) {
try {
// Get a non-cached transport
- fourth = pool.getAnyTransport(servers, false).getSecond();
+ fourth = pool.getAnyTransport(servers.subList(0, 1),
false).getSecond();
Review comment:
I made the following improvements to the test
- Use servers.subList(0,1) for everything
- Strengthened the LIFO check by pulling three things off to check for LIFO
order instead of just one
- Pulled the redundant while loops into a function
- Improved the comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
