ctubbsii commented on a change in pull request #1798:
URL: https://github.com/apache/accumulo/pull/1798#discussion_r533686689
##########
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java
##########
@@ -47,6 +46,7 @@
*/
public class VisMetricsGatherer
implements MetricsGatherer<Map<String,ArrayList<VisibilityMetric>>> {
+ static final String KEY_HASH_ALGORITHM = "SHA-256";
Review comment:
> This is an odd one. I am not sure what we are using the HASH to
encrypt here. If it is just to prevent leaking data then I _think_ it would be
OK to use the NON_CRYPTO_USE_HASH_ALGORITHM
@milleruntime I think this was moved here at my request to keep
serialization-related constants local to the serialization code, rather than to
rely on some global constant, which could have a multitude of uses. I think
it's fine here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
