milleruntime commented on a change in pull request #1798:
URL: https://github.com/apache/accumulo/pull/1798#discussion_r533700645



##########
File path: 
core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java
##########
@@ -47,6 +46,7 @@
  */
 public class VisMetricsGatherer
     implements MetricsGatherer<Map<String,ArrayList<VisibilityMetric>>> {
+  static final String KEY_HASH_ALGORITHM = "SHA-256";

Review comment:
       I don't think this is serializing anything.  I thought this method was 
only used by the `rfile-info` command. The only use i can find of 
`printMetircs()` is here: 
https://github.com/apache/accumulo/blob/6a74b4667e3bd33e34b5262c5dd8ea64167fb657/core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java#L291




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to