ctubbsii commented on a change in pull request #1798:
URL: https://github.com/apache/accumulo/pull/1798#discussion_r533711549
##########
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java
##########
@@ -47,6 +46,7 @@
*/
public class VisMetricsGatherer
implements MetricsGatherer<Map<String,ArrayList<VisibilityMetric>>> {
+ static final String KEY_HASH_ALGORITHM = "SHA-256";
Review comment:
That constant can be left inside this class, because it's not being used
as some sort of overall crypto strategy that necessitates it be aligned with
how the other constant is being used... it's just an arbitrary choice for this
particular visibility metric output format (or "serialization algorithm") and
relates to nothing else. So, it can/should be a local constant held closer to
the rest of that metric serialization algorithm. That's all I mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
