milleruntime commented on a change in pull request #2025:
URL: https://github.com/apache/accumulo/pull/2025#discussion_r616871274



##########
File path: 
core/src/main/java/org/apache/accumulo/core/constraints/DefaultKeySizeConstraint.java
##########
@@ -53,16 +53,14 @@ public String getViolationDescription(short violationCode) {
       return NO_VIOLATIONS;
 
     List<Short> violations = new ArrayList<>();
-
+    int size = mutation.getRow().length;
     for (ColumnUpdate cu : mutation.getUpdates()) {
-      int size = mutation.getRow().length;

Review comment:
       I wasn't sure but to me the `row ID` is an integral part of the Key and 
a user could very easily create a key larger than the constraint if they have a 
large `row ID`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to