milleruntime commented on a change in pull request #2025:
URL: https://github.com/apache/accumulo/pull/2025#discussion_r617573072
##########
File path:
core/src/main/java/org/apache/accumulo/core/constraints/DefaultKeySizeConstraint.java
##########
@@ -53,16 +53,14 @@ public String getViolationDescription(short violationCode) {
return NO_VIOLATIONS;
List<Short> violations = new ArrayList<>();
-
+ int size = mutation.getRow().length;
for (ColumnUpdate cu : mutation.getUpdates()) {
- int size = mutation.getRow().length;
Review comment:
Yes but if there aren't any Column updates the row length will be
ignored. Adding this chunk of code to the test will cause it to fail now:
<pre>
m = new Mutation(oversized);
assertEquals(Collections.singletonList(DefaultKeySizeConstraint.MAX__KEY_SIZE_EXCEEDED_VIOLATION),
constraint.check(null, m));
</pre>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
