keith-turner commented on a change in pull request #2025:
URL: https://github.com/apache/accumulo/pull/2025#discussion_r617624979
##########
File path:
core/src/main/java/org/apache/accumulo/core/constraints/DefaultKeySizeConstraint.java
##########
@@ -53,16 +53,14 @@ public String getViolationDescription(short violationCode) {
return NO_VIOLATIONS;
List<Short> violations = new ArrayList<>();
-
+ int size = mutation.getRow().length;
for (ColumnUpdate cu : mutation.getUpdates()) {
- int size = mutation.getRow().length;
Review comment:
> Yes but if there aren't any Column updates the row length will be
ignored.
Ok I see what you are thinking about. Hopefully that case does not matter.
When a mutation has no column updates, the batchwriter [should reject
it](https://github.com/apache/accumulo/blob/8dfe443af55f5d3aacb12fb38c5002dcb61cb772/core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java#L246).
Also if a mutation w/ no column update were to make it through somehow, when
its inserted into the in memory map its [converted to
keys/values](https://github.com/apache/accumulo/blob/8dfe443af55f5d3aacb12fb38c5002dcb61cb772/server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java#L423-L428).
If column updates are empty, then no key values will be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
